Skip to content

Conversation

RoeiRaz
Copy link
Contributor

@RoeiRaz RoeiRaz commented Aug 25, 2019

@simonjayhawkins simonjayhawkins added the Indexing Related to indexing on series/frames, not to indexes themselves label Aug 25, 2019
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add a release note in 1.0.0?

Are there any issues with negative steps other than -1, or is the adjustment to start and stop correct for all negative steps?

@TomAugspurger TomAugspurger added this to the 1.0 milestone Aug 28, 2019
@jbrockmendel
Copy link
Member

LGTM

@WillAyd WillAyd merged commit bc65fe6 into pandas-dev:master Aug 28, 2019
@WillAyd
Copy link
Member

WillAyd commented Aug 28, 2019

Nice PR - thanks @RoeiRaz !

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Indexing Related to indexing on series/frames, not to indexes themselves

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: cannot set Series with reverse slicer

5 participants